Feat(SQL): Save Stored Procedures updated with error state on attempt to create duplicate record or overwrite existing data when not passing the existing record id.
This commit is contained in:
@@ -79,10 +79,27 @@ BEGIN
|
||||
|
||||
CALL parts.p_core_validate_guid ( a_guid );
|
||||
|
||||
DROP TABLE IF EXISTS tmp_Command_Copy;
|
||||
DROP TABLE IF EXISTS tmp_Command;
|
||||
|
||||
CREATE TEMPORARY TABLE tmp_Command (
|
||||
id_command INT
|
||||
id_temp INT
|
||||
, id_command INT
|
||||
, id_command_category INT
|
||||
, name VARCHAR(250)
|
||||
, hand_signal_default_description TEXT
|
||||
, can_have_button BIT
|
||||
, notes TEXT
|
||||
, active BIT
|
||||
, is_new BIT
|
||||
, name_error VARCHAR(250)
|
||||
|
||||
, name_command_category VARCHAR(250)
|
||||
);
|
||||
|
||||
CREATE TEMPORARY TABLE tmp_Command_Copy (
|
||||
id_temp INT
|
||||
, id_command INT
|
||||
, id_command_category INT
|
||||
, name VARCHAR(250)
|
||||
, hand_signal_default_description TEXT
|
||||
@@ -105,7 +122,8 @@ BEGIN
|
||||
|
||||
-- Get data from Temp table
|
||||
INSERT INTO tmp_Command (
|
||||
id_command
|
||||
id_temp
|
||||
, id_command
|
||||
, id_command_category
|
||||
, name
|
||||
, hand_signal_default_description
|
||||
@@ -117,8 +135,16 @@ BEGIN
|
||||
, name_command_category
|
||||
)
|
||||
SELECT
|
||||
COMMAND_T.id_command AS id_command
|
||||
, COMMAND_T.id_command_category AS id_command_category
|
||||
COMMAND_T.id_temp AS id_temp
|
||||
, COALESCE(
|
||||
COMMAND.id_command
|
||||
, COMMAND_T.id_command
|
||||
) AS id_command
|
||||
, COALESCE(
|
||||
COMMAND_T.id_command_category
|
||||
, COMMAND_CATEGORY_NAME.id_command_category
|
||||
, COMMAND.id_command_category
|
||||
) AS id_command_category
|
||||
, COALESCE(
|
||||
COMMAND_T.name
|
||||
, COMMAND.name
|
||||
@@ -140,12 +166,30 @@ BEGIN
|
||||
, COMMAND.active
|
||||
, 1
|
||||
) AS active
|
||||
, CASE WHEN IFNULL(COMMAND_T.id_command, 0) < 1 THEN 1 ELSE 0 END AS is_new
|
||||
-- , CASE WHEN NOT ISNULL(COMMAND_T.id_command) THEN 1 ELSE 0 END AS does_have_valid_command_id
|
||||
, CASE WHEN COALESCE(COMMAND.id_command, COMMAND_T.id_command, 0) < 1 THEN 1 ELSE 0 END AS is_new
|
||||
|
||||
, COMMAND_T.name_command_category AS name_command_category
|
||||
FROM parts.DOG_Command_Temp COMMAND_T
|
||||
LEFT JOIN parts.DOG_Command COMMAND ON COMMAND_T.id_command = COMMAND.id_command
|
||||
LEFT JOIN parts.DOG_Command_Category COMMAND_CATEGORY_NAME
|
||||
ON COMMAND_T.name_command_category = COMMAND_CATEGORY_NAME.name
|
||||
LEFT JOIN parts.DOG_Command COMMAND
|
||||
ON COMMAND_T.id_command = COMMAND.id_command
|
||||
OR (
|
||||
(
|
||||
COMMAND_T.id_command_category = COMMAND.id_command_category
|
||||
OR COMMAND_CATEGORY_NAME.id_command_category = COMMAND.id_command_category
|
||||
)
|
||||
AND COMMAND_T.name = COMMAND.name
|
||||
AND (
|
||||
COMMAND.hand_signal_default_description IS NULL
|
||||
OR COMMAND_T.hand_signal_default_description <=> COMMAND.hand_signal_default_description
|
||||
)
|
||||
AND COMMAND_T.can_have_button = COMMAND.can_have_button
|
||||
AND (
|
||||
COMMAND.notes IS NULL
|
||||
OR COMMAND_T.notes <=> COMMAND.notes
|
||||
)
|
||||
)
|
||||
WHERE COMMAND_T.guid = a_guid
|
||||
;
|
||||
|
||||
@@ -162,7 +206,7 @@ BEGIN
|
||||
SET t_COMMAND.name_error = CONCAT(
|
||||
COALESCE(COMMAND_CATEGORY.name, t_COMMAND.id_command_category, '(No Command Category)')
|
||||
, ' - '
|
||||
, COALESCE(COMMAND.name, t_COMMAND.id_command, '(No Command)')
|
||||
, COALESCE(COMMAND.name, t_COMMAND.name, t_COMMAND.id_command, '(No Command)')
|
||||
)
|
||||
;
|
||||
|
||||
@@ -172,6 +216,7 @@ BEGIN
|
||||
SELECT COUNT(*) FROM tmp_Command;
|
||||
END IF;
|
||||
|
||||
/*
|
||||
-- Find missing id_command_category by name_command_category
|
||||
UPDATE tmp_Command t_COMMAND
|
||||
INNER JOIN parts.DOG_Command_Category COMMAND_CATEGORY ON t_COMMAND.name_command_category = COMMAND_CATEGORY.name
|
||||
@@ -205,6 +250,7 @@ BEGIN
|
||||
SELECT * FROM tmp_Command;
|
||||
SELECT COUNT(*) FROM tmp_Command;
|
||||
END IF;
|
||||
*/
|
||||
|
||||
-- Validation
|
||||
-- Missing mandatory fields
|
||||
@@ -253,6 +299,173 @@ BEGIN
|
||||
WHERE ISNULL(t_COMMAND.can_have_button)
|
||||
;
|
||||
END IF;
|
||||
|
||||
-- Duplicates
|
||||
INSERT INTO tmp_Command_Copy (
|
||||
id_temp
|
||||
, id_command
|
||||
, id_command_category
|
||||
, name
|
||||
, hand_signal_default_description
|
||||
, notes
|
||||
, active
|
||||
, is_new
|
||||
, name_error
|
||||
)
|
||||
SELECT
|
||||
t_COMMAND.id_temp
|
||||
, t_COMMAND.id_command
|
||||
, t_COMMAND.id_command_category
|
||||
, t_COMMAND.name
|
||||
, t_COMMAND.hand_signal_default_description
|
||||
, t_COMMAND.notes
|
||||
, t_COMMAND.active
|
||||
, t_COMMAND.is_new
|
||||
, t_COMMAND.name_error
|
||||
FROM tmp_Command t_COMMAND
|
||||
;
|
||||
|
||||
IF a_debug = 1 THEN
|
||||
SELECT COUNT(*) AS Count_Temp_Command FROM tmp_Command;
|
||||
SELECT COUNT(*) AS Count_Temp_Command_Copy FROM tmp_Command_Copy;
|
||||
|
||||
WITH
|
||||
Combined_Commands AS (
|
||||
SELECT
|
||||
COMMAND.id_command
|
||||
, COMMAND.id_command_category
|
||||
, COMMAND.name
|
||||
, IFNULL(
|
||||
t_COMMAND_COPY.name_error
|
||||
, CONCAT(
|
||||
COALESCE(COMMAND_CATEGORY.name, t_COMMAND_COPY.id_command_category, '(No Command Category)')
|
||||
, ' - '
|
||||
, COALESCE(COMMAND.name, t_COMMAND_COPY.name, t_COMMAND_COPY.id_command, '(No Command)')
|
||||
)
|
||||
) AS name_error
|
||||
FROM parts.DOG_Command COMMAND
|
||||
LEFT JOIN tmp_Command_Copy t_COMMAND_COPY
|
||||
ON COMMAND.id_command_category = t_COMMAND_COPY.id_command_category
|
||||
AND COMMAND.name = t_COMMAND_COPY.name
|
||||
INNER JOIN parts.DOG_Command_Category COMMAND_CATEGORY ON COMMAND.id_command_category = COMMAND_CATEGORY.id_command_category
|
||||
WHERE t_COMMAND_COPY.is_new = 1
|
||||
UNION
|
||||
SELECT
|
||||
t_COMMAND.id_command
|
||||
, t_COMMAND.id_command_category
|
||||
, t_COMMAND.name
|
||||
, t_COMMAND.name_error
|
||||
FROM tmp_Command t_COMMAND
|
||||
)
|
||||
, Duplicate_Command_Row_Numbers AS (
|
||||
SELECT
|
||||
COMBINED_COMMAND.id_command
|
||||
, COMBINED_COMMAND.id_command_category
|
||||
, COMBINED_COMMAND.name
|
||||
, COMBINED_COMMAND.name_error
|
||||
, ROW_NUMBER() OVER (PARTITION BY COMBINED_COMMAND.id_command_category, COMBINED_COMMAND.name ORDER BY COMBINED_COMMAND.name_error ASC) AS index_command_as_duplicate
|
||||
FROM Combined_Commands COMBINED_COMMAND
|
||||
)
|
||||
SELECT *
|
||||
FROM Duplicate_Command_Row_Numbers;
|
||||
END IF;
|
||||
|
||||
IF EXISTS (
|
||||
WITH
|
||||
Combined_Commands AS (
|
||||
SELECT
|
||||
COMMAND.id_command
|
||||
, COMMAND.id_command_category
|
||||
, COMMAND.name
|
||||
, IFNULL(
|
||||
t_COMMAND_COPY.name_error
|
||||
, CONCAT(
|
||||
COALESCE(COMMAND_CATEGORY.name, t_COMMAND_COPY.id_command_category, '(No Command Category)')
|
||||
, ' - '
|
||||
, COALESCE(COMMAND.name, t_COMMAND_COPY.name, t_COMMAND_COPY.id_command, '(No Command)')
|
||||
)
|
||||
) AS name_error
|
||||
FROM parts.DOG_Command COMMAND
|
||||
LEFT JOIN tmp_Command_Copy t_COMMAND_COPY
|
||||
ON COMMAND.id_command_category = t_COMMAND_COPY.id_command_category
|
||||
AND COMMAND.name = t_COMMAND_COPY.name
|
||||
INNER JOIN parts.DOG_Command_Category COMMAND_CATEGORY ON COMMAND.id_command_category = COMMAND_CATEGORY.id_command_category
|
||||
WHERE t_COMMAND_COPY.is_new = 1
|
||||
UNION
|
||||
SELECT
|
||||
t_COMMAND.id_command
|
||||
, t_COMMAND.id_command_category
|
||||
, t_COMMAND.name
|
||||
, t_COMMAND.name_error
|
||||
FROM tmp_Command t_COMMAND
|
||||
)
|
||||
, Duplicate_Command_Row_Numbers AS (
|
||||
SELECT
|
||||
COMBINED_COMMAND.id_command
|
||||
, COMBINED_COMMAND.id_command_category
|
||||
, COMBINED_COMMAND.name
|
||||
, COMBINED_COMMAND.name_error
|
||||
, ROW_NUMBER() OVER (PARTITION BY COMBINED_COMMAND.id_command_category, COMBINED_COMMAND.name ORDER BY COMBINED_COMMAND.name_error ASC) AS index_command_as_duplicate
|
||||
FROM Combined_Commands COMBINED_COMMAND
|
||||
)
|
||||
SELECT *
|
||||
FROM Duplicate_Command_Row_Numbers DUPLICATE_COMMAND
|
||||
WHERE DUPLICATE_COMMAND.index_command_as_duplicate > 1
|
||||
GROUP BY DUPLICATE_COMMAND.id_command_category, DUPLICATE_COMMAND.name
|
||||
) THEN
|
||||
INSERT INTO tmp_Msg_Error (
|
||||
id_type
|
||||
, code
|
||||
, msg
|
||||
)
|
||||
WITH
|
||||
Combined_Commands AS (
|
||||
SELECT
|
||||
COMMAND.id_command
|
||||
, COMMAND.id_command_category
|
||||
, COMMAND.name
|
||||
, IFNULL(
|
||||
t_COMMAND_COPY.name_error
|
||||
, CONCAT(
|
||||
COALESCE(COMMAND_CATEGORY.name, t_COMMAND_COPY.id_command_category, '(No Command Category)')
|
||||
, ' - '
|
||||
, COALESCE(COMMAND.name, t_COMMAND_COPY.name, t_COMMAND_COPY.id_command, '(No Command)')
|
||||
)
|
||||
) AS name_error
|
||||
FROM parts.DOG_Command COMMAND
|
||||
LEFT JOIN tmp_Command_Copy t_COMMAND_COPY
|
||||
ON COMMAND.id_command_category = t_COMMAND_COPY.id_command_category
|
||||
AND COMMAND.name = t_COMMAND_COPY.name
|
||||
INNER JOIN parts.DOG_Command_Category COMMAND_CATEGORY ON COMMAND.id_command_category = COMMAND_CATEGORY.id_command_category
|
||||
WHERE t_COMMAND_COPY.is_new = 1
|
||||
UNION
|
||||
SELECT
|
||||
t_COMMAND.id_command
|
||||
, t_COMMAND.id_command_category
|
||||
, t_COMMAND.name
|
||||
, t_COMMAND.name_error
|
||||
FROM tmp_Command t_COMMAND
|
||||
)
|
||||
, Duplicate_Command_Row_Numbers AS (
|
||||
SELECT
|
||||
COMBINED_COMMAND.id_command
|
||||
, COMBINED_COMMAND.id_command_category
|
||||
, COMBINED_COMMAND.name
|
||||
, COMBINED_COMMAND.name_error
|
||||
, ROW_NUMBER() OVER (PARTITION BY COMBINED_COMMAND.id_command_category, COMBINED_COMMAND.name ORDER BY COMBINED_COMMAND.name_error ASC) AS index_command_as_duplicate
|
||||
FROM Combined_Commands COMBINED_COMMAND
|
||||
)
|
||||
SELECT
|
||||
v_id_type_error_bad_data
|
||||
, v_code_type_error_bad_data
|
||||
, CONCAT('Attempt to create duplicate or overwrite existing Commands on: ', GROUP_CONCAT(DUPLICATE_COMMAND.name_error SEPARATOR ', ')) AS msg
|
||||
FROM Duplicate_Command_Row_Numbers DUPLICATE_COMMAND
|
||||
WHERE DUPLICATE_COMMAND.index_command_as_duplicate > 1
|
||||
GROUP BY
|
||||
DUPLICATE_COMMAND.id_command_category
|
||||
, DUPLICATE_COMMAND.name
|
||||
;
|
||||
END IF;
|
||||
|
||||
-- Permissions
|
||||
-- Can Create
|
||||
@@ -420,8 +633,9 @@ BEGIN
|
||||
SELECT * from tmp_Command;
|
||||
END IF;
|
||||
|
||||
DROP TEMPORARY TABLE tmp_Command;
|
||||
DROP TEMPORARY TABLE tmp_Msg_Error;
|
||||
DROP TEMPORARY TABLE tmp_Command_Copy;
|
||||
DROP TEMPORARY TABLE tmp_Command;
|
||||
|
||||
IF a_debug = 1 THEN
|
||||
CALL parts.p_core_debug_timing_reporting ( v_time_start );
|
||||
@@ -442,12 +656,24 @@ from parts.DOG_Command_Temp
|
||||
select COUNT(*)
|
||||
from parts.DOG_Command_Temp
|
||||
;
|
||||
INSERT INTO demo.DOG_Dog_Change_Set ( comment, id_user_updated_last_by )
|
||||
VALUES ( 'Nullify empty hand_signal_default_descriptions.', 1 )
|
||||
;
|
||||
|
||||
UPDATE demo.DOG_Command C
|
||||
SET
|
||||
C.hand_signal_default_description = NULL
|
||||
, C.id_change_set = (SELECT DCS.id_change_set FROM demo.DOG_Dog_Change_Set DCS ORDER BY DCS.id_change_set DESC LIMIT 1)
|
||||
WHERE C.hand_signal_default_description = ''
|
||||
;
|
||||
|
||||
*/
|
||||
|
||||
|
||||
|
||||
|
||||
DELETE FROM demo.DOG_Command C
|
||||
WHERE C.id_command > 260;
|
||||
DELETE FROM demo.DOG_Command_Temp;
|
||||
SELECT *
|
||||
/*
|
||||
@@ -475,9 +701,9 @@ INSERT INTO parts.DOG_Command_Temp (
|
||||
VALUES (
|
||||
-1 -- id_command
|
||||
, 1 -- id_command_category
|
||||
, 'Bathing' -- name
|
||||
, 'Bath' -- name
|
||||
, 'Burp and juice' -- hand_signal_default_description
|
||||
, 1 -- can_have_category
|
||||
, 1 -- can_have_button
|
||||
, 'Sweet' -- notes
|
||||
, 1 -- active
|
||||
, 'ripplesipplenippletippledipplekipple'
|
||||
|
||||
Reference in New Issue
Block a user