admin/dog_training
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix(JS): Commands page and Dog Command Links page fix on dirty triggering and new row default values.

Browse Source
This commit is contained in:
Teddy Middleton-Smith
2025-07-12 20:04:26 +01:00
parent 4954c63d84
commit d1c803ae03
6 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
static/dist/js/main.bundle.js vendored
View File

@@ -2590,7 +2590,7 @@ var PageDogCommands = /*#__PURE__*/function (_TableBasePage) {
key: "postInitialiseRowNewCallback", key: "postInitialiseRowNewCallback",
value: function postInitialiseRowNewCallback(tbody) { value: function postInitialiseRowNewCallback(tbody) {
var newRows = tbody.querySelectorAll('tr.' + flagRowNew); var newRows = tbody.querySelectorAll('tr.' + flagRowNew);
var newestRow = newRows[newRows.length - 1]; var newestRow = newRows[0];
var clickableElementsSelector = ['td.' + flagDog + ' div.' + flagDog, ',td.' + flagCommandCategory + ' div.' + flagCommandCategory, ',td.' + flagCommand + ' div.' + flagCommand].join(''); var clickableElementsSelector = ['td.' + flagDog + ' div.' + flagDog, ',td.' + flagCommandCategory + ' div.' + flagCommandCategory, ',td.' + flagCommand + ' div.' + flagCommand].join('');
newestRow.querySelectorAll(clickableElementsSelector).forEach(function (clickableElement) { newestRow.querySelectorAll(clickableElementsSelector).forEach(function (clickableElement) {
clickableElement.click(); clickableElement.click();
@@ -2615,12 +2615,12 @@ var PageDogCommands = /*#__PURE__*/function (_TableBasePage) {
}, { }, {
key: "hookupTextareasHandSignalDefaultDescription", key: "hookupTextareasHandSignalDefaultDescription",
value: function hookupTextareasHandSignalDefaultDescription() { value: function hookupTextareasHandSignalDefaultDescription() {
this.hookupChangeHandlerTableCells(idTableMain + ' td.' + flagHandSignalDefaultDescription + ' textarea'); this.hookupChangeHandlerTableCells(idTableMain + ' td.' + flagHandSignalDefaultDescription + ' .' + flagHandSignalDefaultDescription);
} }
}, { }, {
key: "hookupFieldsCanHaveButton", key: "hookupFieldsCanHaveButton",
value: function hookupFieldsCanHaveButton() { value: function hookupFieldsCanHaveButton() {
this.hookupChangeHandlerTableCells(idTableMain + ' td.' + flagCanHaveButton + ' input'); this.hookupChangeHandlerTableCells(idTableMain + ' td.' + flagCanHaveButton + ' .' + flagCanHaveButton);
} }
}, { }, {
key: "leave", key: "leave",
@@ -2733,7 +2733,7 @@ var PageDogDogCommandLinks = /*#__PURE__*/function (_TableBasePage) {
}, { }, {
key: "hookupTextareasHandSignalDescription", key: "hookupTextareasHandSignalDescription",
value: function hookupTextareasHandSignalDescription() { value: function hookupTextareasHandSignalDescription() {
this.hookupChangeHandlerTableCells(idTableMain + ' td.' + flagHandSignalDescription + ' textarea'); this.hookupChangeHandlerTableCells(idTableMain + ' td.' + flagHandSignalDescription + ' .' + flagHandSignalDescription);
} }
}, { }, {
key: "leave", key: "leave",

2
static/dist/js/main.bundle.js.map vendored
View File

File diff suppressed because one or more lines are too long

6
static/js/pages/dog/commands.js
View File

@@ -63,7 +63,7 @@ export default class PageDogCommands extends TableBasePage {
} }
postInitialiseRowNewCallback(tbody) { postInitialiseRowNewCallback(tbody) {
let newRows = tbody.querySelectorAll('tr.' + flagRowNew); let newRows = tbody.querySelectorAll('tr.' + flagRowNew);
let newestRow = newRows[newRows.length - 1]; let newestRow = newRows[0];
let clickableElementsSelector = [ let clickableElementsSelector = [
'td.' + flagDog + ' div.' + flagDog 'td.' + flagDog + ' div.' + flagDog
, ',td.' + flagCommandCategory + ' div.' + flagCommandCategory , ',td.' + flagCommandCategory + ' div.' + flagCommandCategory
@@ -90,10 +90,10 @@ export default class PageDogCommands extends TableBasePage {
); );
} }
hookupTextareasHandSignalDefaultDescription() { hookupTextareasHandSignalDefaultDescription() {
this.hookupChangeHandlerTableCells(idTableMain + ' td.' + flagHandSignalDefaultDescription + ' textarea'); this.hookupChangeHandlerTableCells(idTableMain + ' td.' + flagHandSignalDefaultDescription + ' .' + flagHandSignalDefaultDescription);
} }
hookupFieldsCanHaveButton() { hookupFieldsCanHaveButton() {
this.hookupChangeHandlerTableCells(idTableMain + ' td.' + flagCanHaveButton + ' input'); this.hookupChangeHandlerTableCells(idTableMain + ' td.' + flagCanHaveButton + ' .' + flagCanHaveButton);
} }
leave() { leave() {

2
static/js/pages/dog/dog_command_links.js
View File

@@ -75,7 +75,7 @@ export default class PageDogDogCommandLinks extends TableBasePage {
this.hookupFieldsActive(); this.hookupFieldsActive();
} }
hookupTextareasHandSignalDescription() { hookupTextareasHandSignalDescription() {
this.hookupChangeHandlerTableCells(idTableMain + ' td.' + flagHandSignalDescription + ' textarea'); this.hookupChangeHandlerTableCells(idTableMain + ' td.' + flagHandSignalDescription + ' .' + flagHandSignalDescription);
} }
leave() { leave() {

2
templates/components/dog/_row_command.html
View File

@@ -15,7 +15,7 @@
{{ model.ATTR_VALUE_CURRENT }} {{ model.ATTR_VALUE_PREVIOUS }} /> {{ model.ATTR_VALUE_CURRENT }} {{ model.ATTR_VALUE_PREVIOUS }} />
</td> </td>
<td class="{{ model.FLAG_CAN_HAVE_BUTTON }}"> <td class="{{ model.FLAG_CAN_HAVE_BUTTON }}">
<input type="checkbox" checked class="{{ model.FLAG_CAN_HAVE_BUTTON }}" {{ model.ATTR_VALUE_CURRENT }} {{ model.ATTR_VALUE_PREVIOUS }} /> <input type="checkbox" class="{{ model.FLAG_CAN_HAVE_BUTTON }}" {{ model.ATTR_VALUE_CURRENT }} {{ model.ATTR_VALUE_PREVIOUS }}="false" />
</td> </td>
<td class="{{ model.FLAG_NOTES }}"> <td class="{{ model.FLAG_NOTES }}">
<input type="text" <input type="text"

4
todo.txt
View File

@@ -10,3 +10,7 @@ UI warning for attempt to create duplicate
Dog Command Links page Dog filter - many replicated options Dog Command Links page Dog filter - many replicated options
Layout logo Layout logo
Create new command - can have button default value broken
Command - default hand signal description field not triggering on change dirty
Dog Command Link - hand signal description field not triggering on change dirty