Fix: bugs, cleanup.

static/PostgreSQL/71212_fn_TCG_MTG_Game_Player_Get_Many.sql

@@ -38,12 +38,45 @@ BEGIN
 	
 	-- Outputs
 
+	WITH User_Name AS (
+		SELECT
+			TCG_USER.user_id
+			, CASE
+				WHEN
+						TRIM(COALESCE(TCG_USER.firstname, '')) <> ''
+					AND TRIM(COALESCE(TCG_USER.surname, '')) <> ''
+				THEN CONCAT(
+					  TRIM(COALESCE(TCG_USER.firstname, '')) <> ''
+					, ' '
+					, TRIM(COALESCE(TCG_USER.surname, '')) <> ''
+				)
+				WHEN TRIM(COALESCE(TCG_USER.firstname, '')) <> ''
+				THEN TRIM(COALESCE(TCG_USER.firstname, '')) <> ''
+				ELSE TRIM(COALESCE(TCG_USER.surname, '')) <> ''
+			END AS name
+		FROM tcg.public.TCG_User TCG_USER
+	)
     RETURN QUERY SELECT
           PLAYER.player_id
         , PLAYER.game_id
     	, PLAYER.user_id
     	, PLAYER.deck_id
-        , PLAYER.name
+        , CASE
+			WHEN TRIM(COALESCE(PLAYER.name, '')) <> ''
+			THEN TRIM(COALESCE(PLAYER.name, '')) <> ''
+			WHEN
+					USER_NAME.name <> ''
+				AND TRIM(COALESCE(DECK.name, '')) <> ''
+			THEN CONCAT(
+				  USER_NAME.name <> ''
+				, ' - '
+				, TRIM(COALESCE(DECK.name, '')) <> ''
+			)
+			ELSE CONCAT(
+				  'Player '
+				, CAST(PLAYER.display_order AS VARCHAR)
+			)
+		END AS name
         , PLAYER.notes
         , PLAYER.display_order
         , PLAYER.active
@@ -54,6 +87,9 @@ BEGIN
         , PLAYER.change_set_id
     FROM tcg.public.TCG_MTG_Game_Player PLAYER
     INNER JOIN tcg.public.TCG_MTG_Game GAME ON PLAYER.game_id = GAME.game_id
+	-- LEFT JOIN tcg.public.TCG_User TCG_USER ON PLAYER.user_id = TCG_USER.user_id
+	LEFT JOIN User_Name USER_NAME ON PLAYER.user_id = USER_NAME.user_id
+	LEFT JOIN tcg.public.TCG_MTG_Deck DECK ON PLAYER.deck_id = DECK.deck_id
     WHERE
             (
                 (
@@ -90,9 +126,9 @@ $$;
 
 SELECT *
 FROM tcg.public.FN_TCG_MTG_Game_Player_Get_Many (
-      a_get_all_game := TRUE
+      a_get_all_game := FALSE
     , a_get_inactive_game := FALSE
-    , a_game_ids := ''
+    , a_game_ids := '34'
     , a_require_all_id_filters_met := TRUE 
     , a_require_any_id_filters_met := FALSE 
 )
@@ -102,7 +138,7 @@ SELECT *
 FROM tcg.public.TCG_MTG_Game
 ;
 SELECT *
-FROM tcg.public.tcg_mtg_game_player_temp -- TCG_MTG_Game_Player_Temp
+FROM tcg.public.TCG_MTG_Game_Player_Temp
 ;
 SELECT *
 FROM tcg.public.TCG_MTG_Game_Player